request for review and testing: default file name

[Dirk Hohndel]

On Sep 10, 2012, at 11:04 PM, Henrik Brautaset Aronsen wrote:

> Den 10.09.12 23:55, skrev Dirk Hohndel:
>> Henrik Brautaset Aronsen <subsurface at henrik.synth.no> writes:
>> 
>>> I can't quite get it to work:
>>> 
>>> 1) Open Subsurface
>>> 2) In Preferences, verify that ~/Library/Application
>>> Support/Subsurface/henrik.xml is selected
>>> 3) Log » Import » XML file » test1.xml
>>> 4) Save
>>> 5) Quit
>>> 6) Re-open Subsurface
>>> 7) No log is opened?!
>>> 
>>> There's nothing written to ~/Library/Application
>>> Support/Subsurface/henrik.xml either (but the folder is created). And if
>>> I leave out 4), Subsurface doesn't ask me to save.
>> 
>> Yes. Two bugs. Incorrect folder permissions. Incorrect "things were
>> changed" logic. Both fixed in my latest code that I'll send out for
>> review, soon.
> 
> These bugs still apply.  Or maybe your fixes still haven't been added to the defaultfile branch?

I did some more testing of this. With step 4 it works on MacOS. Reliably. Without step 4 it doesn't, depending on how you exit the program.

If you click on the red window close button (which sends the delete-event) things work fine.
But if you use the subsurface->Quit menu entry or Command-Q, then even though the callbacks for 'quit' are hooked up correctly (at least when running this on Linux), those callbacks are never called and you aren't asked if you want to save your file…

Any idea why this isn't working as intended on MacOS?

/D