Patch - move model related code from MainWindow and adjustments.

Tomaz Canabrava tcanabrava at kde.org
Sun Apr 21 18:12:36 PDT 2013


    Moves the DiveTrip model related code to models.h

    The DiveTripModel was implemented in three parts:
    DiveTripModel.h
    DiveTripModel.cpp
    MainWindow.cpp ( the code to populate the model )
    This patch changes the DiveTripModel from it's original
    implementation to the file models.h, wich should store
    all models ( dirk requested the Qt developers to not create
    2 files per class, but instead to use a file for functionality,
    and data-models are one functionality. )

    Besides that, this code cleans up a bit the style ( removed
    operator<< for .push_back, const references where they apply,
    moved the internal DiveItem class to the .cpp since it should be
    visible only to the DiveTripModel class, and redesigned the
    current interface of the model to be identical of the GTK one
    ( used the UTF8-star and 2 subscribed, for instance. )

    Amit ( the creator of the original code ) should comment here if it's
    ok with my changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130421/5c818091/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: moveModelFromMain.diff
Type: application/octet-stream
Size: 16241 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130421/5c818091/attachment.obj>


More information about the subsurface mailing list