[PATCH] Fixing SP handling in planner, adding event

Dirk Hohndel dirk at hohndel.org
Sat Feb 2 12:02:32 PST 2013


Jan Schubert <Jan.Schubert at GMX.li> writes:

> Fixes bug in planner which prevents from bailing out (setpoint = 0). 
> Also introduces events for changing setpoints in planner.
> It also fixes the eventtype for gaschange from SAMPLE_EVENT_GASCHANGE 
> (O2 only) to SAMPLE_EVENT_GASCHANGE2 (O2/He).

Hehe - those two are different as far as libdivecomputer is concerned,
but since they are 100% compatible from a data structure point of view,
we treat them the same. So this wasn't really a bug :-)

I understand the logic of the setpoint change, but that makes the
setpoint planning inconsistent from the gas planning for OC. But I guess
that's better than not being able to plan bailouts.

So I'll take this patch.

/D


More information about the subsurface mailing list