[PATCH] Fixing SP handling in planner, adding event

[Jan Schubert]

On 02/02/13 21:02, Dirk Hohndel wrote:
> Jan Schubert <Jan.Schubert at GMX.li> writes:
>
> > Fixes bug in planner which prevents from bailing out (setpoint = 0).
> > Also introduces events for changing setpoints in planner.
> > It also fixes the eventtype for gaschange from SAMPLE_EVENT_GASCHANGE
> > (O2 only) to SAMPLE_EVENT_GASCHANGE2 (O2/He).
>
> Hehe - those two are different as far as libdivecomputer is concerned,
> but since they are 100% compatible from a data structure point of view,
> we treat them the same. So this wasn't really a bug :-)

OK, Sry. I just dig into the code and thought, hey lets do it right :-).

> I understand the logic of the setpoint change, but that makes the
> setpoint planning inconsistent from the gas planning for OC. But I guess
> that's better than not being able to plan bailouts.

Yes, it is different and maybe this could be a reason to switch to 
another method of defining CC/OC/Setpoint in future releases. Planing 
bailout scenarious is common to do gas planning and worst case 
scenarious. But there are also rebreather around specified for only 
certain depth and scenarios (like deco online). And BTW: bailout 
rebreather is something which gets more popular in the next time...

Thx,
Jan