Small temperature import bug

[Dirk Hohndel]

On Feb 17, 2013, at 12:13 PM, Henrik Brautaset Aronsen wrote:

> Linus Torvalds wrote:
>> Anyway, if I'm right, something like the attached (BUT TOTALLY
>> UNTESTED) patch that simply moves the fixup_dive_dc() code up migth
>> fix it.
>> 
>> But maybe the fixup_dive_dc() code already relies on some of the
>> values having been fixed up. That's why I say "totally untested",
>> there might be some other ordering dependency that I didn't notice.
>> 
>> Dirk? Not-signed-off-yet-due-to-lack-of-testing, but if Henrik acks
>> it, feel free to add my sign-off.
>> 
> 
> I can't guarantee any unwanted side-effects, but it looks good to go.  Temperatures show up immediately after the import, and the resulting saved XML is identical to the XML before patching.
> 
> Acked-by: Henrik Brautaset Aronsen <subsurface at henrik.synth.no>

Ok, pushed out, but I'm a bit nervous about this one.

Reading the code it seems this would be OK to do but I would appreciate if people could do some more testing, especially downloading from divecomputers.

/D


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4130 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130217/2d420982/attachment.bin>