[PATCH 1/3] Replace the == bashism with the posix equivalent =.

Dirk Hohndel dirk at hohndel.org
Sun Feb 24 06:46:54 PST 2013


Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn at axis.com> writes:

> On Sun, 24 Feb 2013, Lutz Vieweg wrote:
>> On 02/24/2013 10:48 AM, Cristian Ionescu-Idbohrn wrote:
>> > diff --git a/scripts/get-version b/scripts/get-version
>> > index 4da0185..4427ca0 100755
>> > --- a/scripts/get-version
>> > +++ b/scripts/get-version
>> > @@ -5,7 +5,7 @@
>> >   #      (see below)
>> >
>> >   set -eu
>> > -#set -x
>> > +set -x
>>
>> This looks like a non-intentional remnant from debugging, right?
>
> Right.  Corrected by the 0003- patch.

Actually, it was the 0002 patch but I took the liberty of just fixing
both patches.

Thanks for cleaning this up. Much appreciated. Shell programming has
always been something I hate :-)

And as a side effect this now of course will run on Ubuntu as well which
doesn't use bash as /bin/sh (there are many reasons why I hate Ubuntu -
I have finally gotten 12.10 installed on a spare laptop and was reminded
of many of the ways in which I dislike the way Ubuntu does Linux... but
I was able to reproduce the icon problem that is clearly caused by
Ubuntu trying to "fix" something in gtk. And I can see the odd
highlighting change that has been reported here with the divelist when
changing sort order (that one is caused by their butt ugly  color scheme
/ theme).

Yuck.

/D


More information about the subsurface mailing list