[PATCH 1/3] Replace the == bashism with the posix equivalent =.
cristian.ionescu-idbohrn at axis.com
Sun Feb 24 07:51:15 PST 2013
On Sun, 24 Feb 2013, Dirk Hohndel wrote:
> Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn at axis.com> writes:
> > On Sun, 24 Feb 2013, Lutz Vieweg wrote:
> >> On 02/24/2013 10:48 AM, Cristian Ionescu-Idbohrn wrote:
> >> > diff --git a/scripts/get-version b/scripts/get-version
> >> > index 4da0185..4427ca0 100755
> >> > --- a/scripts/get-version
> >> > +++ b/scripts/get-version
> >> > @@ -5,7 +5,7 @@
> >> > # (see below)
> >> >
> >> > set -eu
> >> > -#set -x
> >> > +set -x
> >> This looks like a non-intentional remnant from debugging, right?
> > Right. Corrected by the 0003- patch.
> Actually, it was the 0002 patch but I took the liberty of just fixing
> both patches.
That's fine with me. I should have squashed those small patches before
> Thanks for cleaning this up. Much appreciated.
I'll just mention an observation. If the script is run with a 'v3'
argument (no dots), the output will look like this:
but that can be catched, as dots will be 0.
> Shell programming has always been something I hate :-)
Like most other languages, it gets easier after a while ;)
> And as a side effect this now of course will run on Ubuntu as well which
> doesn't use bash as /bin/sh (there are many reasons why I hate Ubuntu -
And it'll be easier on debian too (where the system default shell is dash)
as well as on all other derivatives.
> I have finally gotten 12.10 installed on a spare laptop and was reminded
> of many of the ways in which I dislike the way Ubuntu does Linux... but
> I was able to reproduce the icon problem that is clearly caused by
> Ubuntu trying to "fix" something in gtk.
More information about the subsurface