[PATCH] Fix GPS import from divinglog

[Dirk Hohndel]

On Feb 25, 2013, at 7:17 AM, Linus Torvalds wrote:

> I'm not convinced xslt is any better. The language is so unreadable as to result in it being unmaintainable. I actually tried to write a stupid script to add ask the crazy XML syntax on top of something more readable, but I gave up.
> 
> So the whole notion of having xml transformations for foreign formats is a nice idea, but it is destroyed my the horrible mess that is xslt.

I agree that xslt has its shortcomings. But I'd rather have the preprocessing step and a sane parser than a parser that gets more and more promiscuous and has more and more subtle bugs that are a massive pain to track down.

Miika is doing a great job maintaining our XSLT files - and I am slowly starting to wrap my mind around the insane syntax.

So I repeat my statement. I'd really much rather have a tight parser for our format. And a preprocessing step that turns foreign formats into ours.

Because overall, that is  much easier to keep running. Otherwise we find a bug in format X. We change the parser. Now we need to check that formats A, B, C, D, E - G are not broken by this.
With the XSLT pre-processing we change the one XSLT style sheet - nothing else is affected.

And the more we add formats (and I want to add all the formats we could possibly parse), the more convinced I am that this is the right step.

/D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4130 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130225/86099450/attachment.bin>