Autogroup settings change

[Dirk Hohndel]

"Lubomir I. Ivanov" <neolit123 at gmail.com> writes:

> On 2 January 2013 03:36, Dirk Hohndel <dirk at hohndel.org> wrote:
>>
>>
>> I just committed another change that had been on my todo list since
>> forever. The autogroup settings were criminally insanely stupid. Having
>> that twice (preferences and menu) and having different semantics for
>> when a change would be saved in the config was just nuts. And saving it
>> in the config was a mistake to begin with. This is much more a per file
>> feature.
>>
>> Please take a look.
>>
>
> one problem i've noticed:
> - start with a blank file
> - import dives/test*.xml
> - switch "autogroup" on
> - dive 22 becomes an expandable row

For the record - my change didn't actually touch the autogroup code
itself, only the way the variable "autogroup" is set (and stored
persisitently between sessions).

But looking at your instructions to recreate the problem - dive 26 is
actually now in a trip with 22, yet instead of a trip row we do appear
to use the actual dive 22 as the expandable row... and given the
'Location' info for dive 26 this clearly is a dive that was merged from
two dives...

Linus, even though this is almost certainly because the test dives have
bogus dates, this does sound like a bug.

/D