[PATCH] Sort "loose" dives properly in-between trips

Dirk Hohndel dirk at hohndel.org
Mon Jan 7 13:54:19 PST 2013


Linus Torvalds <torvalds at linux-foundation.org> writes:

> On Mon, Jan 7, 2013 at 10:57 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
>>
>> With all that said - should I apply the patch and we test it in tree, or
>> should I wait for Miika to come back and say "yes, this is good"?
>
> I think the patch we should apply is the attached one instead.
>
> HOWEVER, I can't test it with your and my dives, because the deco
> calculations get unhappy and get stuck in some infinite loop (I think
> this may be related to the other report about test-dives). Just try it
> (with or without this patch) by doing a simple

I just pushed a rather crude 'fix' for this. It doesn't address the
underlying issue, but it at least bails out from the infinite loop and
prints a warning instead.

It's a hack, but it should allow you to test this patch of yours (and
send it with commit message / SOB)

/D


More information about the subsurface mailing list