[Patch] Add facility to edit nicknames / remove nickname entry from list

Dirk Hohndel dirk at hohndel.org
Fri Jan 18 07:36:22 PST 2013

Hi Amit,

I just pushed this patch. Well, not THIS patch... this email was somehow
damaged and the patch didn't apply, but a visual comparison showed that
it was the same as what you had sent me earlier.

As I had mentioned I did a few changes to whitespace and coding style to
make this more look like Subsurface code. Please take a look at what I
just pushed out to see what I mean.

One thing I didn't notice when I checked the code yesterday:

'delete' closes the dialog. why? Shouldn't it just redraw without the
deleted entry and continue? Also, "Apply" would more consistently be
named "OK".

Thanks for all the work on this!

And welcome to the list of Subsurface contributors.

What's the next thing you'll be working on? :-)


Amit Chaudhuri <amit.k.chaudhuri at gmail.com> writes:

> Hi all,
> attached allows user to edit one or more nick name entries in a single
> session.  Entries can also be removed individually.
> Based on mock up by Lubomir Ivanov and various conversations from Dirk.
> Thanks to both.
> My first contribution, so let me know if I can change anything to make life
> easier..
> Signed-off-by: Amit Chaudhuri <amit.k.chaudhuri at gmail.com>
> Regards,
> Amit

More information about the subsurface mailing list