[PATCH] Rewrite gtk dive selection tracking logic

Linus Torvalds torvalds at linux-foundation.org
Mon Jan 28 22:44:30 PST 2013

On Mon, Jan 28, 2013 at 10:29 PM, Linus Torvalds
<torvalds at linux-foundation.org> wrote:
> This hopefully fixes the problem Henrik saw. Henrik, mind testing?

Btw, I'll have to fix up some of the special cases for selecting
expanded dive trips etc. So it's not complete, but the approach is
simpler and more straightforward, and I think this one is fixable,
which I don't think the old code was.

Anyway, I'd love to hear whether you can now delete dives with
impunity, but I do realize that the selection code isn't perfect.
Selecting an expanded dive trip currently selects just the trip - not
the dives under it. And while selecting a collapsed trip does the
right thing, when you then *expand* that collapsed trip, that seems to
trigger a selection change event and then gtk messes up the selection,
and we believe the new gtk selection. Or something like that.


More information about the subsurface mailing list