[PATCH] Make relative times default in planner.

[Lubomir I. Ivanov]

On 23 March 2013 17:30, Robert C. Helling <helling at atdotde.de> wrote:
>
> On Mar 23, 2013, at 3:08 PM, Lubomir I. Ivanov wrote:
>
>> - i don't think a forwarded patch will apply using "git am" without
>> removing the quoted lines (>) first.
>
> That was my first go at git prepare-patch. I failed sending it from mail program on my mac.
>
>> - not sure if due to the forward, but the patch has leading spaces
>> instead of tabs
>
> Bugger. That should now be better (after using a combination of Aquamacs which does not use the settings in .emacs for some reason) and vi (to insert proper spaces).

actually, the email "client" over here does not respect tabs unless i
view the email in "raw form". sorry my bad.

>
>> - perhaps it will better to have this:
>>
>>>>      }
>>>> +     else {
>>>> +             if(*text == '@') {
>>
>> formed as:
>>
>> } else if (*text == '@') {
>>
>> }
>>
>> since there is only one "if" statement inside the "else" branch.
>>
>
> OK.
>
>> - please correct me if i'm wrong, but shouldn't there also be a
>> modification in starttime_focus_out_cb(), where the "is_rel" flag has
>> to be taken into account for this to work?
>
>
> I don't get what you are aiming at here.
>

i got confused because validate_time() is used for both start time and
for segments, but absolute times are not supported in the start time
box. so as far as i understand it, this patch only makes the absolute
time format explicit via "@" for segment times, but also makes the
default time format relative, even without entering "+".

lubomir
--