My progress in HTML export.

Gehad Elrobey gehadelrobey at gmail.com
Sun Jul 20 22:16:55 PDT 2014


Hi miika,

On Sun, Jul 20, 2014 at 8:02 AM, Miika Turkia <miika.turkia at gmail.com>
wrote:

> New bugs I spotted:
>
> - The tooltip on temperature graphs shows actually the time (concatenated
> with temperature unit).
>

what is it supposed to show? I think this is consistent will all the other
curves in the profile.

I Also fixed the previous patches, and attached some new patches with them.
There are still three bugs that I am working on them now.


> - I am not sure about the search of location - e.g. if I write "Mexico
> somethingthatdoesnotexist", I get all the locations in Mexico.
> - Zooming in (ctrl++) and out (ctrl+-) and restoring zoom level (ctrl+0)
> on firefox does not rescale the graph properly
> - The heading and gaschange switches should use the value field from the
> event, not the type field (type is still internal to subsurface, and does
> not provide any useful information to the users, on the other hand value
> would e.g. tell what gas we changed to)
>

Regarding the event value, is exporting the event value as a number is
useful? or there is some enum strings that must be shown instead?


> - If I go to next dive on detailed view, and hit one extra right arrows
> after reaching the last dive, first click on left does not change the
> selection, only re-clicking on left does
>
> I'll still do a bit of poking around once I have more time...
>
> miika
>
>
> On Sat, Jul 19, 2014 at 6:30 AM, Gehad Elrobey <gehadelrobey at gmail.com>
> wrote:
>
>> I Attached some bug fixes, Still working on the remaining bugs.
>>
>> Regards,
>> Gehad.
>>
>>
>> On Tue, Jul 15, 2014 at 11:22 PM, Tomaz Canabrava <tcanabrava at kde.org>
>> wrote:
>>
>>> On Tue, Jul 15, 2014 at 4:31 PM, Anton Lundin <glance at acc.umu.se> wrote:
>>> > On 15 July, 2014 - Anton Lundin wrote:
>>> >
>>> >> On 15 July, 2014 - Miika Turkia wrote:
>>> >>
>>> >> > A few more bugs:
>>> >> > - Trimix dives are missing He content (use e.g. test20.xml for
>>> testing
>>> >> > purposes) - Reported by Roberto, but mailing list was not included
>>> >>
>>> >> Gaah. This is code that uses the event data straight off. In the case
>>> of
>>> >> SAMPLE_EVENT_GASCHANGE especially we need to map the event to the
>>> >> available cylinders and that way figure out which gas we are using.
>>> >>
>>> >> Almost every place where we use get_gasmix_from_event we should be
>>> using
>>> >> get_cylinder_index instead and grab the "real" gasmix from the
>>> cylinder,
>>> >> except the case where get_gasmix_from_event is called from
>>> >> get_cylinder_index =)
>>> >>
>>> >>
>>> >> This was more work than anticipated when i first gave it a stab. If no
>>> >> one else untangles this I'll give it another stab later.
>>> >>
>>> >>
>>> >
>>> > Gaah 2.
>>> >
>>> > I of course miss-read the report and i was talking about what we write
>>> > in the regular-non-html-ui.
>>> >
>>> > I found another bug.
>>>
>>> :P
>>>
>>> > //Anton
>>> _______________________________________________
>>> subsurface mailing list
>>> subsurface at hohndel.org
>>> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140721/972e9beb/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-HTML-Fix-the-viewed-search-results-when-change-the-n.patch
Type: text/x-patch
Size: 982 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140721/972e9beb/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-HTML-rescale-dive-profile-with-page-zoom-in-out.patch
Type: text/x-patch
Size: 693 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140721/972e9beb/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-HTML-fix-moving-to-previous-dive-by-keyboard-arrows.patch
Type: text/x-patch
Size: 977 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140721/972e9beb/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-HTML-fix-SAC-units.patch
Type: text/x-patch
Size: 1346 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140721/972e9beb/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-HTML-add-event-value-to-the-detailed-view.patch
Type: text/x-patch
Size: 1905 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140721/972e9beb/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-HTML-Add-notes-variable-to-the-JSON-file-even-if-not.patch
Type: text/x-patch
Size: 1122 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140721/972e9beb/attachment-0015.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-HTML-Fix-the-pressure-axis-if-no-pressure-samples.patch
Type: text/x-patch
Size: 887 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140721/972e9beb/attachment-0016.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-HTML-fix-searching-tags-from-the-detailed-view.patch
Type: text/x-patch
Size: 5905 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140721/972e9beb/attachment-0017.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-HTML-list-lib-Seach-must-support-spaces-in-the-searc.patch
Type: text/x-patch
Size: 2877 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140721/972e9beb/attachment-0018.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-HTML-don-t-add-photos-or-dive-status-if-exporting-li.patch
Type: text/x-patch
Size: 1211 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140721/972e9beb/attachment-0019.bin>


More information about the subsurface mailing list