My progress in HTML export.

[Miika Turkia]

With a very brief skipping through the code, I started to wonder if there
is a reason why only d1 is declared?
+var d1;
+function canvas_draw(){
+    document.getElementById("chart1").innerHTML="";
+    d1 = new Array();
+    d2 = new Array();

list_lib.js has some white space inconsistencies.

Time scale needs some adjusting as shown in the attachment.

Cylinder information has some undefined fields even though I they are
available in the log (start and end pressures and O2).

Bookmarks contains all the events, so it should probably be re-named to
Events. And the event type (numeric value) is probably not interesting to
users (internal enum value).

miika


On Fri, Jun 27, 2014 at 3:40 AM, Gehad Elrobey <gehadelrobey at gmail.com>
wrote:

> I attached another 3 patches on the top of those I sent yesterday.
>
> Now we use jqplot to draw the dive profile which is not as beautiful as
> Highcharts, but we get a nice compatible license.
> The 5th patch will add some whitespaces errors, This is the included code
> from jqplot library.
> I will work on adding some more curves to the plot and also fixing the
> padding in the detailed view.
>
> Regards,
> Gehad
>
>
> On Wed, Jun 25, 2014 at 11:55 PM, Gehad Elrobey <gehadelrobey at gmail.com>
> wrote:
>
>> This patches add the events to list to the detailed view.
>> This events will be rendered later to the profile.
>>
>> Regards,
>> Gehad
>>
>>
>> On Wed, Jun 25, 2014 at 12:36 PM, Miika Turkia <miika.turkia at gmail.com>
>> wrote:
>>
>>> Libdivecomputer.c has events structure that shows meaning of the events
>>> (function handle_event). Just check from a sample dive that I am correct.
>>> Tablet is a poor tool to check code...
>>>
>>> I believe the deleted means that user has deleted the event and does not
>>> want to see it anymore.
>>>
>>> miika
>>> On Jun 24, 2014 10:04 PM, "Gehad Elrobey" <gehadelrobey at gmail.com>
>>> wrote:
>>>
>>>> I was lately working on exporting event list, I will send some patches
>>>> for that today.
>>>>
>>>> I don't understand well the event structure in dive.h , I don't know
>>>> what is the 'deleted' flag, and the type what do these numbers mean ? is
>>>> there a look-up table for there meaning or some enums? some help in this
>>>> will be appreciated.
>>>>
>>>> My to do for this week:
>>>>
>>>> - prototype the dive profile with jqplot (which is under GPL license).
>>>> - Fix the detailed view style (Tweak up the css)
>>>> - fix any semantic errors in the dive profile or the events list and
>>>> add missing values.
>>>> - will have some clean documentation and polishing to the javascript
>>>> code.
>>>>
>>>> Regards,
>>>> Gehad
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Tue, Jun 24, 2014 at 4:41 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>>>>
>>>>> On Tue, Jun 24, 2014 at 04:01:40PM +0300, Miika Turkia wrote:
>>>>> >
>>>>> > I will send Gehad's patch-set from the 17th with my signed-off as a
>>>>> > separate set of mail (using git e-mail), as poor Internet connection
>>>>> > over here forces me to use HTML-only gmail and that does not seem to
>>>>> > support attachments. I will skip the one from 19th that switches to
>>>>> > Highchart as the license is unfortunately not acceptable for
>>>>> > Subsurface.
>>>>>
>>>>> Thanks - I just applied them and will push in a moment, internet
>>>>> connection permitting :-)
>>>>>
>>>>> /D
>>>>>
>>>>
>>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140627/804462ac/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screenshot - 06272014 - 01:44:08 PM.png
Type: image/png
Size: 50007 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140627/804462ac/attachment-0001.png>