Few bugs and a feature req from testing Subsurface

[Dirk Hohndel]

On Sat, 2014-03-15 at 21:16 -0700, Dirk Hohndel wrote:
> I have several doubts about the commit. 
> 
> a) I don't know why the selection with ->items() didn't work. Switching
> over to ->itemAt() produced the desired result, but still, something is
> odd here.

This one I'm still curious about. What I have appears to work in my
testing, but I don't understand why Tomaz' code doesn't work.

> b) even though I also brought back the hide event code from the old
> profile, for some reason that doesn't work at all. I'm calling hide() on
> the DiveEventItem (I had lots of qDebug() in the code to verify that)
> but it still stays visible.

Hehe, I fixed this one. Turns out that I had added code to the
plotDives() method a while back that unconditionally makes all events
visible -- even with a comment that this will need fixing in the
future...

Oh well, I now added a helper method to DiveEventItem so we can query
such an item if it shouldBeVisible() - and now things appear to work.

So now we can add gas changes, add bookmarks, hide events, unhide events
(if there are hidden events) and remove events.

That should cover the interactions with events that we used to have...

/D