Don't crash when selecting a planned dive

Robert C. Helling helling at
Fri May 16 15:17:06 PDT 2014


this looks like a patch but us actually a cry for help: When I plan a dive and save it, subsurface crashes when I select that dive from the dive list. This comes about as upon that selection, the current dive is cleared which involves clearing the cylinder model but that emits the cylinderModelChanged signal which then makes the planner profile redraw (which is not on the screen and fails). This patch fixes that by making the signal receiver check if the planner is active. But this is a hack, the signal should be disconnected from that slot when the planned dive gets saved. But I failed to do so due to lack of QObject knowledge.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Don-t-crash-when-selecting-a-planned-dive.patch
Type: application/octet-stream
Size: 1292 bytes
Desc: not available
URL: <>
-------------- next part --------------

Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics  
                      Scientific Coordinator                                   
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik    
print "Just another   Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339       
    stupid .sig\n"; 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <>

More information about the subsurface mailing list