Don't crash when selecting a planned dive

Robert C. Helling helling at atdotde.de
Sat May 17 00:34:08 PDT 2014


On 17 May 2014, at 00:29, Tomaz Canabrava <tcanabrava at kde.org> wrote:

Tomaz,
> Ill provide a patch for that today and send on top of yours, thanks for the help tracking this down.
> 
Thanks a lot.
> Btw, its easy to fix if you want too. 
> Just figure out what the broken connection and call disconnect()  on it.
> 

Not that I had not tried that already but failed. Here is what I figured out (we are in qt-ui/diveplanner.cpp). The connection I am concerned about is set up in l 154

 	connect(plannerModel, SIGNAL(cylinderModelEdited()), this, SLOT(drawProfile()));

which is in DivePlannerGraphics.

I guess, that connection should be removed somewhere close to the end of void DivePlannerPointsModel::createPlan()
as well as probably void DivePlannerPointsModel::cancelPlan()

but it was not clear to me how to reference the DivePlannerGraphics object (to which drawProfile belongs) from there. So I failed at composing the appropriate disconnect.

Best
Robert



--                                                                              
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO 
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics  
                      Scientific Coordinator                                   
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik    
print "Just another   Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339       
    stupid .sig\n";   http://www.atdotde.de 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140517/ece81093/attachment.html>


More information about the subsurface mailing list