Patches.

[Dirk Hohndel]

On Sat, May 24, 2014 at 01:14:53PM -0300, Tomaz Canabrava wrote:
> >>
> >> The jumpyness is because we are creating a dive from the plan
> >> everytime a move is done,
> >
> > Should we do this differently? In order to get the deco stuff right, I
> > don't think we can do this differently. But maybe we can be smarter about
> > telling the profile what has to change?
> 
> We can - but then, we will lose some stuff - mostly the colors of the
> velocities on the polygon.
> ( that's what I meant by color border below ), since we are showing an
> actual dive, everything
> on the profile is a real dive, so the velocity colors on the borders
> and other stuff is ready.
> 
> if this thing is not important, I can speed up quite a lot by using
> another model to display stuff
> instead of the dive profile model for that.

I would much rather reuse as much code as possible. That was one of the
goals of the new profile, remember?

> > What I do notice is that the screen is all blue (instead of cream) - I
> > guess that's OK as it indicates we are in create dive mode.
> > The other thing that I noticed is that if I cancel "Add Dive" the profile
> > of the selected dive is not restored. I have to switch dives to get the
> > profile back.
> 
> 'cancel' and 'ok' are a bit bugged, but on my todo list. :)

OK

>  I'm trying to make the profille really workable, then I'll fix the rest.

Understood.

> >> The same way that we allowed in the past but it was removed, there's
> >> already a widget that allows that - but currently only for planner
> >> mode.
> >
> > We need to integrate this in a consistent way into add dive as well.
> 
> we do. it can be a tab on the info panel.

Yes. Or it could temporarily replace the dive list - you can't interact
with that during add dive / plan dive, anyway

/D