[PATCH] Rework slot to quiet down Qt5 warning

Dirk Hohndel dirk at hohndel.org
Sun May 25 15:44:36 PDT 2014


Did you really want to just simply remove the connect? Maybe there's some
implicit magic that I'm missing, but to me this looks wrong.

/D

On Mon, May 26, 2014 at 12:06:56AM +0200, Anton Lundin wrote:
> diff --git a/qt-ui/downloadfromdivecomputer.cpp b/qt-ui/downloadfromdivecomputer.cpp
> index 681b0d2..71f428b 100644
> --- a/qt-ui/downloadfromdivecomputer.cpp
> +++ b/qt-ui/downloadfromdivecomputer.cpp
> @@ -72,7 +72,6 @@ DownloadFromDCWidget::DownloadFromDCWidget(QWidget *parent, Qt::WindowFlags f) :
>  		if (default_dive_computer_product)
>  			ui.product->setCurrentIndex(ui.product->findText(default_dive_computer_product));
>  	}
> -	connect(ui.product, SIGNAL(currentIndexChanged(int)), this, SLOT(on_product_currentIndexChanged()), Qt::UniqueConnection);
>  	if (default_dive_computer_device)
>  		ui.device->setEditText(default_dive_computer_device);
>  


More information about the subsurface mailing list