[PATCH] Rework slot to quiet down Qt5 warning
Tomaz Canabrava
tcanabrava at kde.org
Sun May 25 15:54:58 PDT 2014
doesn't.
On Sun, May 25, 2014 at 7:44 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
> Did you really want to just simply remove the connect? Maybe there's some
> implicit magic that I'm missing, but to me this looks wrong.
>
> /D
>
> On Mon, May 26, 2014 at 12:06:56AM +0200, Anton Lundin wrote:
>> diff --git a/qt-ui/downloadfromdivecomputer.cpp b/qt-ui/downloadfromdivecomputer.cpp
>> index 681b0d2..71f428b 100644
>> --- a/qt-ui/downloadfromdivecomputer.cpp
>> +++ b/qt-ui/downloadfromdivecomputer.cpp
>> @@ -72,7 +72,6 @@ DownloadFromDCWidget::DownloadFromDCWidget(QWidget *parent, Qt::WindowFlags f) :
>> if (default_dive_computer_product)
>> ui.product->setCurrentIndex(ui.product->findText(default_dive_computer_product));
>> }
>> - connect(ui.product, SIGNAL(currentIndexChanged(int)), this, SLOT(on_product_currentIndexChanged()), Qt::UniqueConnection);
>> if (default_dive_computer_device)
>> ui.device->setEditText(default_dive_computer_device);
>>
Doesn't
the form 'on_member_dignal(vars) is autoconnected by Qt.
the MainWindow works mainly that way.
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
More information about the subsurface
mailing list