[PATCH] Rework slot to quiet down Qt5 warning
glance at acc.umu.se
Sun May 25 23:45:00 PDT 2014
On 25 May, 2014 - Tomaz Canabrava wrote:
> On Sun, May 25, 2014 at 7:44 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
> > Did you really want to just simply remove the connect? Maybe there's some
> > implicit magic that I'm missing, but to me this looks wrong.
> > /D
> > On Mon, May 26, 2014 at 12:06:56AM +0200, Anton Lundin wrote:
> >> diff --git a/qt-ui/downloadfromdivecomputer.cpp b/qt-ui/downloadfromdivecomputer.cpp
> >> index 681b0d2..71f428b 100644
> >> --- a/qt-ui/downloadfromdivecomputer.cpp
> >> +++ b/qt-ui/downloadfromdivecomputer.cpp
> >> @@ -72,7 +72,6 @@ DownloadFromDCWidget::DownloadFromDCWidget(QWidget *parent, Qt::WindowFlags f) :
> >> if (default_dive_computer_product)
> >> ui.product->setCurrentIndex(ui.product->findText(default_dive_computer_product));
> >> }
> >> - connect(ui.product, SIGNAL(currentIndexChanged(int)), this, SLOT(on_product_currentIndexChanged()), Qt::UniqueConnection);
> >> if (default_dive_computer_device)
> >> ui.device->setEditText(default_dive_computer_device);
> the form 'on_member_dignal(vars) is autoconnected by Qt.
> the MainWindow works mainly that way.
Yepp, there is some implicit magic there. on_vendor_currentIndexChanged
is autoconnected that way si i thought that its cousin
on_product_currentIndexChanged should be managed in the same manner.
Anton Lundin +46702-161604
More information about the subsurface