Subsurface: sample to plot_data pressure transfer

[Dirk Hohndel]

Willem,

Why would this email go only to me? Please send Subsurface questions to
the mailing list.

On Thu, May 29, 2014 at 09:03:40PM +0200, Willem Ferguson wrote:
> 
> I have made quite a bit of progress (I think) with respect to rebreather
> dive logs. I read in the rebreather dive log and transfer the data to the
> plot_data structure in plot_info. I have only added two scalar variables,
> one in the sample structure and one in the plot_data structure to store the
> pressure of the diluent cylinder.
> 
> But I am trying to handle the diluent pressure data in exactly the same way
> as the the data for the oxygen cylinder which is the default first cylinder
> and whose info is normally stored in the pressure variable of plot_data. The
> diluent pressure data are not handled in the same way at the moment. The
> reason is:
> 
> When the sample data are read from xml in parse_xml, all the pressure
> variables for the appropriate cylinder pressure are there and stored in the
> samples. However, when the same sample structures are accessed in profile.c
> (populate_plot_entries) to construct a plot_info, then, sensibly, all the
> duplicate pressure values have already been stripped out of the sample
> structures within the dive. I want to see that the diluent pressure data are
> handled in exactly the same way, but I cannot find the code that strips out
> the duplicate pressure values out of the samples. I have made a fairly
> thorough check of dive.c, parse_xml.c and profile.c. Are you perhaps
> prepared to point me in the right direction?

This is code that Linus wrote a long time ago.
Look at fixup_dive_dc() in dive.c

/D