[CCR PATCH] reorganise po2 calculations

Dirk Hohndel dirk at hohndel.org
Mon Oct 13 22:08:09 PDT 2014


I took the patch with tiny cleanups as it looked sane to me, but I think I
the last couple of days have shown that you are much better than me in
spotting issues in that code :-)

Would you please take a look? Willem is leaving tonight and I want to make
sure we get this figured out in the next 12 hours or so.



On Mon, Oct 13, 2014 at 10:24:36PM +0200, Willem Ferguson wrote:
> CCR patch. Reorganise the oxygen partial pressure calculations.
> This patch responds to the side effects that the CCR code has had with
> respect to ceilings in OC dives and dive plans. Dive ceilings are now
> calculated apparently correctly. The following were performed:
> 1) remove the oxygen sensor and setpoint fields from the gas_pressures
> structure.
> 2) Re-insert setpoint and oxygen sensor fields in the plot_data structure.
> 3) Remove the algorithm that reads the o2 sensor data and calculates the
> pressures.po2
>    value from function fill_pressures() in dive.c and save it as a separate
> function
>    calc_ccr_po2() in profile.c.
> 4) Activate calc_ccr_po2 from function fill_pressures() in profile.c.
> 5) Move the relative position of the call to fill_pressures() within the
>    function create_polt_info_new() in profile.c.
> Signed-off-by: willem ferguson <willemferguson at zoology.up.ac.za>

More information about the subsurface mailing list