[PATCH 0/5] HiDPI support, round 2

Giuseppe Bilotta giuseppe.bilotta at gmail.com
Sun Oct 19 07:15:17 PDT 2014

Apparently three of the patches in the previous round got lost along
the way. In the mean time, I've also found another couple of minor
issues with tableview, so here's a rehash of the last three patches of
the previous round, plus two additional patches.

The two new patches handle:

* the situation where, when using the GTK+ style, the layout margin
was set too small, making the table overlap the label; this is now fixed
in a style-independent way (should work also on Mac OS X, which was
marked as dubious in the comments, so please test), and it's also

* the plus button was sometimes sized too large for the label, which
resulted in clipping. It's now reduced to fit in the label height if the
default choice is too large. A possible alternative approach would be to
make the label taller, suggestions welcome.

Giuseppe Bilotta (5):
  [HiDPI] Resolution-independent DiveEventItem icon sizes
  [HiDPI] Resolution-indepent dive pictures
  [HiDPI] Resolution-independent trash icon
  [HiDPI] Fix tableview margins
  [HiDPI] TableView: fix button sizing

 qt-ui/divepicturewidget.cpp     |  5 ++++-
 qt-ui/diveplanner.cpp           |  8 ++++++-
 qt-ui/models.cpp                | 36 ++++++++++++++++++++++++++++---
 qt-ui/models.h                  |  3 +++
 qt-ui/profile/diveeventitem.cpp |  9 ++++++--
 qt-ui/tableview.cpp             | 47 ++++++++++++++++++++++++++++++++++-------
 6 files changed, 93 insertions(+), 15 deletions(-)


More information about the subsurface mailing list