File::encodeName() and Utf8 as the default encoding under Qt5

[Lubomir I. Ivanov]

On 29 October 2014 18:02, Thiago Macieira <thiago at macieira.org> wrote:
> On Wednesday 29 October 2014 17:32:58 Lubomir I. Ivanov wrote:
>> now, i know how to fix the issue by simply not use File::encodeName()
>> at all on Win32 and use QString::toUtf8() instead but is there a
>> cleaner way with no #ifdefs?
>>
>> not sure if QTextCodec::setCodecForLocale() should be set to Utf8 on
>> Win32...
>
> Hmm... I'm not sure what will happen if you setCodecForLocale on Windows, I've
> never tried.
>

just tried setting it to UTF-8 and the filenames work again
(QFile::encodeName()).
but i really have no idea of the more global consequences of this. if
it breaks other important areas perhaps the attached patch should not
be applied.

lubomir
--
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-qt-qui.cpp-set-the-locale-codec-to-UTF-8-on-Win32.patch
Type: application/octet-stream
Size: 1042 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20141029/1484e8c4/attachment.obj>