OSTCTools import support

[Dirk Hohndel]

On Sat, Apr 04, 2015 at 11:24:35AM +0200, Salvador Cuñat wrote:
> Hi Dirk.
> 
> 2015-04-02 18:18 GMT+02:00 Dirk Hohndel <dirk at hohndel.org>:
> 
> >
> > Here's what I'd like to see. Either don't do the datetime rename or if you
> > do it, have it in its own patch with nothing else mixed in.
> > Then, if you want to change all the error returns to show these errors to
> > the user, do that in one patch and nothing else.
> > As a third patch you can do the split out into a separate function,
> > explaining any logic changes that you are doing.
> >
> >
> Attached are the reworked patches.  I've get rid of the fprintf messages as
> they should be shown to the user in mainwindow viia report_error(),
> erased renaming of datetime as it was pointless, and reworked all other
> considerations.

Much better.

> Around the data thing in parse_gasmixes() with the pointer changed to
> NULL,  explanation is in 0003 patch.  For this point I've added 0007 patch
> which is not mandatory (but advisable, I think).

I used the patch as it seems to make sense.

> All should apply on master - acaedee159abf

It does. I'm doing some tests and will push it out soon.
Could you send a patch that adds a sample file so that this can be
reasonably tested? So simply add a file OSTCTools-sample.dive under dives

Thanks

/D