fix crash and indentation
Dirk Hohndel
dirk at hohndel.org
Thu Dec 3 13:05:44 PST 2015
On Thu, Dec 03, 2015 at 08:53:43PM +0000, Sebastian Kügler wrote:
> On Thursday, December 03, 2015 12:42:20 Dirk Hohndel wrote:
> > Do we really want this? It seems like a switch statement and we format
> > them with case xxx: at the same indentation level as the switch (to save
> > one level of indentation). This patch shows the problem with not doing
> > that - a LOT of emptyness in the source file (i.e., very deep
> > indentation).
>
> Yes, it's a list of actions (indicated by the [] around it, with a group in
> it. The indentation is currently just not consistent (also inside the actions
> it jumps around, resulting in weirdly placed brackets.
OK, I'll take the patch. This is of course a file I'm working on right now
to do the split of preferences / cloud credentials and to make sure that
the dive list is loaded after the credentials have been entered...
> I'll look into splitting out the action into their own file in a separate
> patch.
OK.
/D
More information about the subsurface
mailing list