Subsurface dive planner - List of findings

[Robert C. Helling]

> On 14 Feb 2015, at 18:43, Stefan Fuchs <sfuchs at gmx.de> wrote:
> 
> I meanwhile found out that the missing gas change information in the calculated plan has also s.th. to do with an "injected" waypoint which I didn't enter but which appears in some cases.
> I do the following:
> - I have a dive in the planner mode with three gases: Tx21/35, EAN50 at 21m and Oxy at 6m
> - Waypoints are:
> 52m    5              Tx21/35
> 52m    15            Tx21/35
> 40m    16            Tx21/35
> 40m    30            Tx21/35
> 21m    32            Tx21/35
> 21m    34            Tx21/35
> 21m    37            EAN50
> - The result I get at the first moment is good. I have a calculated dive plan which shows the gas change to EAN50 at 21m and to Oxy at 6m.
> - Now I save the dive
> - Now when I replan the dive the waypoint list has one more entry:
> 52m    5              Tx21/35
> 52m    15            Tx21/35
> 40m    16            Tx21/35
> 40m    30            Tx21/35
> 21m    32            Tx21/35
> 21m    34            Tx21/35
> 21m    34            Tx21/35     <---  This one added by the tool
> 21m    37            EAN50
> - The calculated dive plan is still ok save the fact that it doesn't show the gas change to EAN50 at 21m any more
> - When I delete the additional 21m  34 entry again manually the result is perfect again but the "injected" entry will appear again and again when replanning the dive

Would you mind mailing me the saved dive? That dive is a bit uncommon, with the repeated depth of 21m and the gas change only later. That might confuse the logic that decides which waypoints to show and which to suppress which is already a bit convoluted, to quote from the source:

		if ((dp->depth == lastdepth && dp->depth != nextdp->depth) || plan_display_transitions || dp->entered || !dp->next || (gaschange && dp->next && dp->depth != nextdp->depth)) {

May I ask why in the first place you entered any waypoints beyond the 40m ones? The 21m stop would have been handled by the planner (with the gas change right at the beginning)?


> 
> 
>>> - When I save a planned dive with two gas changes e.g. to EAN50 and OXY, in the profile view the two gas changes exchange there position. You can even watch the two bottles walking to the other position.
>> 
>> This I cannot reproduce. Please be more specific how to reproduce that behaviour.
> Yeah, this in fact is the most funny issue I found! ;-) Maybe I should do a video of this one?!
> What happens is:
> - I have a dive in the planner mode with three gases: Tx21/35, EAN50 at 21m and Oxy at 6m
> - Waypoints are:
> 52m    5
> 52m    15
> 40m    16
> 40m    30
> - The calculated plan looks perfect with gas changes at 21m and 6m
> - Now I save the plan with the "Speichern" button
> - Now I can really in the profile view watch the cute little tanks for gas change to EAN50 and Oxy walking to each others position

Are you starting from an empty dive list? When I do I cannot reproduce this. Maybe it’s again something with preexisting dives. If you start from an existing dive, would you mind to mail me that as well?

> I already started to type this when Joakims mail arrived which mostly explains my finding because yes, I'm using a OSTC 2N and these "zombie gases" may have been in the gas list of the OSTC. Nevertheless I decided to not delete my description. Maybe it would be worthwhile to fix Subsurface in a way to not copy the unused gases from dive computer to gases for planning while at the same moment not showing them in the list from first moment.

I think at some point I sent a patch to that effect but other people argued that the list of all gases should be what the user wants. I cannot recall the rationale.


> What happens on my side is the following:
> - I select a "real" dive in my logbook where I only used one gas EAN32

Could you send that dive as well? I cannot  reproduce this without.

Best
Robert
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150214/eda88163/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150214/eda88163/attachment.sig>