[PULL REQUEST] GSoC Printing: part 5

[Dirk Hohndel]

On Tue, Jul 28, 2015 at 06:34:36PM +0300, Lubomir I. Ivanov wrote:
> > I am blown away. This is really great work. It's not perfect, there are
> > things that I'd like to see improved, but it is such an amazing
> > step forward for our printing infrastructure.
> 
> thanks, all credit goes to the student.

Of course, Gehad did most of the work, but you have done a fantastic job
mentoring him, pushing for solid solutions and helping him along. I'm very
happy with BOTH of you.

> > Things I noticed in a few minutes of testing:
> >
> > - the profiles always contain the GF on the top... that should only be
> >   there if we show any ceiling
> 
> my terminology is a bit lacking here. could you explain which
> preferences need to be enabled for that to be observed and which
> testXX.xml dive can be used for testing?

Great question. The printing code does something very smart - it uses the
current settings which means people see the things on paper that they see
on screen - and don't see the things that they haven't enabled.

In my case the "toggle calculated ceilings" setting is on (as I want to
see those) and strangely on the screen the "GF 30/70" doesn't bother me at
all, but on the printout I find it odd on dives that don't have a visible
ceiling.

So what someone needs to do is change the profile code to do the right
thing and only show that text if there actually is a ceiling shown.

> there is a flag in the profile widget class "printMode", which if set
> to "true" hides certain things like the tooltip and the profile is
> simply rendered the same way it looks on the user screen. this hasn't
> changed from the previous printer code.

I'm sure you're right. As I said, this was "me after playing with it for a
few minutes".

> > - having the warning triangles but no way to see their text... I think
> >   we should just not print the triangles. Opinions?
> 
> same as the previous printer code. perhaps we should simply hide them
> with "printMode" (as Miika suggests) for now?

Yes. Please.

> > - in the table template, having the location centered looks odd to me
> 
> should be fixed in the template "prettyfication" process.

Yes.

> > - clicking cancel while the print is being created doesn't appear to
> >   interrupt it (but hey, maybe that's ok - the progress bar clearly tells
> >   me what's happening)
> 
> i'm not sure if that's currently possible in a single thread, but we
> may attend to it in the later stages.

As I said, this may be OK - it's just yet another thing that I noticed
while playing with it and figured was worth mentioning.

/D