Current subsurface issues..

Dirk Hohndel dirk at hohndel.org
Sun Jun 14 22:03:35 PDT 2015


On Sun, Jun 14, 2015 at 06:58:56PM -1000, Linus Torvalds wrote:
> On Sun, Jun 14, 2015 at 3:24 PM, Linus Torvalds
> <torvalds at linux-foundation.org> wrote:
> >
> > Our handling of "air time remaining" events is pretty nasty. This is
> > not new, but I noticed just because I added support for it to the EON
> > steel backend now that the v1.1.15 release has airtime support.
> 
> Actually, I take that back.
> 
> I think I just misused the SAMPLE_EVENT_AIRTIME in the EON Steel
> parser. I think it's meant to be an actual warning event, and
> subsurface shows it correctly, and I was wrong to make the EON Steel
> parser generate those events.

I was wondering about that but didn't have the time to check that, yet...

> If we want to actually have a "dive computer reports an air time of X"
> (the same way we have the ndl value), I think we'd have to add a new
> interface for it.

Yes, I agree.

> So I think that we should just remove the EON Steel reporting for now.
> Patch attached.

Thanks. Pushed.

Gaetan - that means there is a new commit on the Subsurface-testing branch
:-)

/D


More information about the subsurface mailing list