Patch for #847

Matthew Vepritskiy matteofichtner at hotmail.com
Wed Mar 18 11:24:10 PDT 2015


> The idea of the two patch rule is for you to demonstrate that you can
> successfully contribute.
I do not argue. I really want to be helpful.

I made another patch. He corrects the error described in the ticket # 847. 
Plus, I have tried to remove the recursion from the function enableEdition ().

Regards, Matthew V.

> Date: Tue, 17 Mar 2015 09:10:40 -0700
> From: dirk at hohndel.org
> To: neolit123 at gmail.com
> CC: matteofichtner at hotmail.com; subsurface at subsurface-divelog.org
> Subject: Re: Patch for #848
> 
> On Tue, Mar 17, 2015 at 02:19:04PM +0200, Lubomir I. Ivanov wrote:
> > On 17 March 2015 at 14:11, Matthew Vepritskiy
> > <matteofichtner at hotmail.com> wrote:
> > > Okay. I see.
> > > At least I was right about the handles.:-(
> > >
> > > This patch is not counted? I have to make another one?
> > >
> > 
> > yes, please do another one. your patches have to be applied for them to count.
> 
> Let me phrase this differently.
> 
> If you had sent a solid patch that for some strange reason I ended up not
> taking, I would certainly have counted it. But commenting out a function
> isn't exactly a strong submission, wouldn't you agree?
> 
> The idea of the two patch rule is for you to demonstrate that you can
> successfully contribute.
> 
> 
> /D
 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150318/8378b39c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_for_ticket_#847
Type: application/octet-stream
Size: 2963 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150318/8378b39c/attachment.obj>


More information about the subsurface mailing list