[PATCH 7/7] main.qml: fix crash on native Win32 desktop

[Lubomir I. Ivanov]

On 19 November 2015 at 14:21, Sebastian Kügler <sebas at kde.org> wrote:
> On Wednesday, November 18, 2015 11:47:00 PM Lubomir I. Ivanov wrote:
>
> I haven't, but it's OK. The difference between Window and ApplicationWindow is
> that the latter has some more properties, which we currently don't use. I'm
> cool with moving to Window for that, *but* we may return to ApplicationWindow
> in the future, for better platform integration of things like menus. Let's
> prevent that crasher for now, though. Holler if I introduce it without
> checkout with you that the crashes aren't still an issue.

when i try a standalone main.qml ApplicationWindow test it works, so
it must be something specific.

>
> I'm not 100% sure about the sign-off procedure, but in case you need it,
> here's my line:
>
> Signed-off-by: Sebastian Kügler <sebas at kde.org>
>

we usually do that when the code passes through you for local pull
reviews and testing.
other than that, on the mailing list here a simply "ACK" in an email
message is enough to signal that you acknowledge the change.

lubomir
--