[PATCH 7/7] main.qml: fix crash on native Win32 desktop

[Sebastian Kügler]

On Thursday, November 19, 2015 02:46:00 PM Lubomir I. Ivanov wrote:
> On 19 November 2015 at 14:21, Sebastian Kügler <sebas at kde.org> wrote:
> > On Wednesday, November 18, 2015 11:47:00 PM Lubomir I. Ivanov wrote:
> > 
> > I haven't, but it's OK. The difference between Window and
> > ApplicationWindow is that the latter has some more properties, which we
> > currently don't use. I'm cool with moving to Window for that, *but* we
> > may return to ApplicationWindow in the future, for better platform
> > integration of things like menus. Let's prevent that crasher for now,
> > though. Holler if I introduce it without checkout with you that the
> > crashes aren't still an issue.
> 
> when i try a standalone main.qml ApplicationWindow test it works, so
> it must be something specific.

If you feel like debugging it, that'd be good of course (but not high 
priority, as I said). I assume you're using the latest Qt, it may well be a 
bug in there (QtQuick code should simply not crash, d'oh!)

>From a cursory glance, maybe it has to do with us not setting some properties 
default in ApplicationWindow, but who knows without debugging.

> > I'm not 100% sure about the sign-off procedure, but in case you need it,
> > here's my line:
> > 
> > Signed-off-by: Sebastian Kügler <sebas at kde.org>
> 
> we usually do that when the code passes through you for local pull
> reviews and testing.
> other than that, on the mailing list here a simply "ACK" in an email
> message is enough to signal that you acknowledge the change.

Alright, thanks!
-- 
sebas

http://www.kde.org | http://vizZzion.org