[PATCH] Restructure preferences UI

Tomaz Canabrava tcanabrava at kde.org
Tue Oct 6 14:15:17 PDT 2015


On Tue, Oct 6, 2015 at 6:11 PM, Dirk Hohndel <dirk at hohndel.org> wrote:

> Hi Joakim
>
> I finally found time to look at this patch.
>
> I'm glad that you are trying to address this bug and the patch does appear
> to improve some aspects of the preferences layout, but I have a few
> issues:
>
> - the email was sent with odd mime headers - mutt tells me that the first
>   attachment is of type "y" which it doesn't know how to decode (so my
>   normal patch automation doesn't work with this email) - but I was able
>   to save it and apply it manually
>
> - the layout of the Graph page is changed quite a bit (and I think this
>   helps to marginally shrink the vertical height of the preferences page
>   by a few pixels), but the new layout has some issues on my system - the
>   inner boxes for GF defaults and CCR default have no margin to the Misc
>   Groupbox - so they appear "glued to the walls" of the Groupbox. Not sure
>   if this is a good description, I'm attaching a screen shot.
>
> So in its current state I don't think I can take this. I'm a little
> hesitant to say if I'd take it with the second issue fixed - this would
> cause additional work for Willem to create new screenshots.
>
> I know that Tomaz wants to redesign the Preferences for 4.6, anyway - so
> I'm not sure what to tell you what to do next...
>

>From your screenshoot, Dirk, it looks an easy fix: it seems that there's no
layout applied in the  bottom 'Misc' widget.
I already changed the way that the preferences dialog *works* on the next
version of subsurface, I didn't changed the UI.

Tomaz


> /D
>
> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151006/4f47c7e8/attachment.html>


More information about the subsurface mailing list