[PATCH] Restructure preferences UI

Joakim Bygdell j.bygdell at gmail.com
Tue Oct 6 22:10:11 PDT 2015


> On 06 Oct 2015, at 23:11, Dirk Hohndel <dirk at hohndel.org> wrote:
> 
> Hi Joakim
> 
> I finally found time to look at this patch.
> 
> I'm glad that you are trying to address this bug and the patch does appear
> to improve some aspects of the preferences layout, but I have a few
> issues:
> 
> - the email was sent with odd mime headers - mutt tells me that the first
>  attachment is of type "y" which it doesn't know how to decode (so my
>  normal patch automation doesn't work with this email) - but I was able
>  to save it and apply it manually

Some thing wrong in my git email config probably.

> 
> - the layout of the Graph page is changed quite a bit (and I think this
>  helps to marginally shrink the vertical height of the preferences page
>  by a few pixels), but the new layout has some issues on my system - the
>  inner boxes for GF defaults and CCR default have no margin to the Misc
>  Groupbox - so they appear "glued to the walls" of the Groupbox. Not sure
>  if this is a good description, I'm attaching a screen shot.

Interesting, there should be a 10px border on the placements of the inner boxes.

> 
> So in its current state I don't think I can take this. I'm a little
> hesitant to say if I'd take it with the second issue fixed - this would
> cause additional work for Willem to create new screenshots.

No worries we can fix the preferences after 4.5.
But they needs to get a better structure.

> 
> I know that Tomaz wants to redesign the Preferences for 4.6, anyway - so
> I'm not sure what to tell you what to do next…

One thing I noticed about your screenshot and what I see on my Mac.
On my Mac the icons in the lefthand column are squashed to match the height of the text beside it.

> 
> /D
> <screenshot.png>

/Jocke



More information about the subsurface mailing list