[PATCH] Restructure preferences UI

[Dirk Hohndel]

On Wed, Oct 07, 2015 at 07:10:11AM +0200, Joakim Bygdell wrote:
> > 
> > - the email was sent with odd mime headers - mutt tells me that the first
> >  attachment is of type "y" which it doesn't know how to decode (so my
> >  normal patch automation doesn't work with this email) - but I was able
> >  to save it and apply it manually
> 
> Some thing wrong in my git email config probably.

I was wondering if you answered "yes" (y) to some question and it took
your response for something else when configuring? It would be nice if you
could look into this because it does make my life a little harder :-/

> > - the layout of the Graph page is changed quite a bit (and I think this
> >  helps to marginally shrink the vertical height of the preferences page
> >  by a few pixels), but the new layout has some issues on my system - the
> >  inner boxes for GF defaults and CCR default have no margin to the Misc
> >  Groupbox - so they appear "glued to the walls" of the Groupbox. Not sure
> >  if this is a good description, I'm attaching a screen shot.
> 
> Interesting, there should be a 10px border on the placements of the inner boxes.

I assumed that it didn't look like this on your screen which is why I sent
the screen shot.

> > So in its current state I don't think I can take this. I'm a little
> > hesitant to say if I'd take it with the second issue fixed - this would
> > cause additional work for Willem to create new screenshots.
> 
> No worries we can fix the preferences after 4.5.
> But they needs to get a better structure.

I completely agree. I was really hoping that we'd get more of this done
EARLY in the 4.5 release cycle but hey, that's the nice thing about open
source, there's always a next release cycle to fix things in.

> > I know that Tomaz wants to redesign the Preferences for 4.6, anyway - so
> > I'm not sure what to tell you what to do next…
> 
> One thing I noticed about your screenshot and what I see on my Mac.
> On my Mac the icons in the lefthand column are squashed to match the height of the text beside it.

Yeah, there's a lot wrong with the preferences. Let's tackle this in a
week or so. Actually, please feel free to continue to work on this... come
up with a new layout that makes more sense, maybe implement it... that way
we can hit the road running once 4.5 is out.

Thanks!

/D