Uemis patch 10-12

[Dirk Hohndel]

On Fri, Sep 11, 2015 at 09:12:18AM +0200, Guido Lerch wrote:
> some code optimisation and cleanup

Thanks, Guido. #10 you had already sent and I pushed it to master
yesterday. I took #11 and 12 and will push them after some more testing
here.

One thought. now that you understand the code better, maybe you can
restructure it to be more readable? The level of indentation is a
screaming testament to the fact that this needs more helper functions. By
breaking out parts of the code into functions with good names (even if
they are used just once) will make the code more readable and more easily
debuggable.

This is again something that could be done one block at a time. So grab
something that's way deeply indented. Think of a good name. Create a
static function and call it from the original spot (making sure the
functionality is otherwise identical). That's one commit.
Now do it again for the next block.

And feel free to remove pointless debug output while you do that.

Makes sense?

Oh, and Herzlichen Glückwunsch zum Geburtstag!

/D