[PATCH] Remove leftover bits between sensors and setpoint

Dirk Hohndel dirk at hohndel.org
Sun Sep 13 09:51:13 PDT 2015


> On Sep 13, 2015, at 8:46 AM, Anton Lundin <glance at acc.umu.se> wrote:
> 
> On 13 September, 2015 - Anton Lundin wrote:
> 
>> This removes leftover bits from when setpoint and sensor values where
>> treated the same way.
>> 
> 
> I was/still are to tired to write good commit messages.
> 
> Here comes some explanation.
> 
> Previously subsurface treated DC_SAMPLE_SETPOINT and DC_SAMPLE_PPO2 the
> same way.
> 
> Back in "Store DC_SAMPLE_PPO2 as a o2 sensor", and "Support multiple o2
> sensor values from libdc", i changed that and started to treat
> DC_SAMPLE_PPO2 as the o2 sensor values they are.
> 
> The po2 variable there was a leftover from when ppo2 and setpoints where
> treated the same way, and should be removed.

So we have a weird hack in the Shearwater support in our libdivecomputer branch
that was trying to work around something there... can you check if that is still useful
or if we should revert that, now that we treat the different sample types correctly?

/D



More information about the subsurface mailing list