[PATCH] Copy coordinates when renaming site

[Linus Torvalds]

On Thu, Apr 14, 2016 at 12:39 PM, Miika Turkia <miika.turkia at gmail.com> wrote:
> Let's not discard our GPS location when editing site name on mobile.

This on the face of it sounds "obviously correct", but the fact is, it's not.

Not obvious, that is.

It might be correct, but it might also not be.

What if you picked the wrong dive site first, got the gps coordinates
from having picked the wrong name, and then you fix the name, not
realizing you now have completely bogus gps coordinates just because
of the intermediate temporary wrong pick.

In other words - changing the name of the dive site in no way means
that we should automatically pick up the old gps information.

We used to have two separate fields that could be edited, and that
made this a no-brainer, and made it very obvious what the right
behavior was. The "divesite" model completely destroyed that. Now gps
information editing is tied into the name, causing these kinds of
problems.

                 Linus