[PATCH] Copy coordinates when renaming site

[Linus Torvalds]

On Thu, Apr 14, 2016 at 8:41 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>
>
> Since we don't autocomplete dive sites on mobile... what behavior do
> you think is the expected behavior if you are on mobile, you have an
> old dive at "Turle Reef" in Maui, with GPS data, and you realize that
> this should of course be "Turtle Reef".
>
> I would assume that you'd want the GPS to stay and the name to be
> updated.

You're making up a scenario where that is true.

But my point was that there are equally good other cases where it wasn't.

If you're fixing a spelling error, then _of_course_ you want the gps to stay.

But if you're editing up the fact that you picked the wrong dive site entirely?

The thing is, I absolutely DETEST this "gps is magic" shit. It's wrong.

Gps isn't magic. We should be able to *edit* it. If you don't want to
change it, then you don't edit it. If you want to change it, you edit
it.

It's really that simple.

The whole "gps has anything what-so-ever to do with name" is pure and
utter garbage. Exactly because it does not. The two are entirely
independent. Sometimes you want to edit just the name. Sometimes you
don't.

Both the mobile _and_ the desktop get this completely wrong, although
with the desktop you at least get the choice. On mobile, as far as I
can tell, you don't actually see the existing gps, but you have the
choice to reset it to the current location.

Why does the name editing have anything at all to do with gps? In
*that* sense I agree with Miika's patch, but I'd just like to see the
actual gps location and be able to edit it. When I just tried on a
dive that does have gps, I saw "--" and a checkbox for "use current
gps".

               Linus