[PATCH 2/2] Adding about page to Subsurface-mobile

Miika Turkia miika.turkia at gmail.com
Wed Feb 10 09:50:00 PST 2016


On Wed, Feb 10, 2016 at 5:29 PM, Sebastian Kügler <sebas at kde.org> wrote:
> On Wednesday, February 10, 2016 05:09:51 PM Miika Turkia wrote:
>> +import QtQuick.Window 2.2
>> +import QtQuick.Dialogs 1.2
>
> Seems unused?
>
>> +       signal accept
>
> What is this used for?

I am quite clueless when it comes to QML so I am quite sure these can
be removed. Some leftover from the Preferences.qml that I used as
starting point.

> Could you attach or link a screenshot to this page? That makes it much easier
> to review the visual aspects.

Here is a screenshot. I'll do the suggested changes if others agree
that it makes sense to have an  About window.

BTW how do I access the splash image on the Image tag (or what these
should be called in QML)? I was trying to use the bigger logo image,
but couldn't figure out how to access it.

miika
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screenshot_20160210-194221.png
Type: image/png
Size: 94836 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160210/80aeaa55/attachment-0001.png>


More information about the subsurface mailing list