Add Weight Field To Print Log Page

[Dirk Hohndel]

On Fri, Feb 26, 2016 at 01:52:34PM +0200, Lubomir I. Ivanov wrote:
> On 26 February 2016 at 12:45, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
> > On 26 February 2016 at 12:02, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
> >> On 26 February 2016 at 09:43, Dirk Hohndel <dirk at hohndel.org> wrote:
> >>> Gehad, Lubomir,
> >>>
> >>> As the resident experts, can you comment?
> >>
> >> i just tested the latest master quickly and the printing of weights
> >> and cylinders is indeed broken.
> >>
> >> Tomaz did some refactoring to moving the helper Dive class to
> >> /subsurface-core/subsurface-qt/DiveObjectHelper.h, which could be the
> >> cause as it was working before.
> >>
> >
> > http://lists.subsurface-divelog.org/pipermail/subsurface/2016-January/023912.html
> > "if you modify the variables in any way let me know so that i can
> > update the docs."
> >
> > and the variables are apparently modified...
> >
> 
> actually Dirk, let me know if we want to NOT break the user interface
> (Grantlee variables), compared to what the docs have.
> 
> two options:
> 1) go with the changes Tomaz did (break the documented variables) and
> add support for printing all the weights and cylinders with something
> like "dive.allWeights", or "dive.allCylinders", as TMK you cannot
> print directly a QStringList from Grantlee (via dive.weights).
> 
> 2) clutter the DiveObjectHelper with some weight0(), ... weightN()
> methods as that's how the old document variables worked.
> 
> i have lost track of what version is currently released and if the
> regression is already in the user hands!
> also, i will be on IRC today if this has to be discussed further.

Sorry - I was away from my computer all day (and the same will be true for
most of the next two days - I'll be back in Portland starting Monday).

I would love to understand what the options are (and I read Tomaz'
response that he's planning to look into that once he's in Portland next
week as well). What works/worked in 4.5.0 vs. 4.5.3 vs. master? What broke
and when (and why)? What are our options to fix this. Both of the options
you offer above sound like they have significany drawbacks, but I'd really
like to know how this would look from a user's perspective. And I don't
really have the time (or, frankly, the experience as I never print
anything so haven't played much with this facility) to figure this out.

/D