[PATCH] Let cns and otu return ints rather than QStrings so they display correctly when accessed from grantlee template Fixes #1085

Lubomir I. Ivanov neolit123 at gmail.com
Mon Jul 18 15:42:53 PDT 2016


On 19 July 2016 at 01:08, Tim Wootton <tim at tee-jay.org.uk> wrote:
> Signed-off-by: Tim Wootton <tim at tee-jay.org.uk>
> ---

hello,

it appears that the commit message has become a part of the commit title.

other than that ACK.
given "int" properties (apparently) work in Grantlee the patch is good.

this small error has slipped in 6f95242f.
QString(m_dive->maxcns), would threat the m_dive->maxcns as QChar and
return a string consisting of a single unicode character.
QString::number(m_dive->maxcns) is the alternative solution.

lubomir
--


More information about the subsurface mailing list