Github issue 412: lbs values

Lubomir I. Ivanov neolit123 at gmail.com
Sat Jun 10 13:30:39 PDT 2017


On 10 June 2017 at 23:13, Linus Torvalds <torvalds at linux-foundation.org> wrote:
> On Sat, Jun 10, 2017 at 12:49 PM, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
>>
>> perhaps both the lrint() calls should be removed and let QString()
>> with 'f' (0/1) handle that?
>
> Agfreed. The whole "lbs = lrint(lbs + 0.05);" thing isn't even a
> sensible thing to do in the first place, and the other version (that
> adds half a lbs) is confused too, since lrint() already rounds.
>
> So ack on your patch.
>

attached is the signed-off patch with a commit message.
maybe Dirk can confirm if we need to handle it differently.

lubomir
--
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-qthelper.cpp-leave-lbs-rounding-to-QString-.arg-with.patch
Type: text/x-patch
Size: 1128 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170610/13fe23f6/attachment.bin>


More information about the subsurface mailing list