4.7 - a few questions and requests

[Dirk Hohndel]

On Sun, Oct 15, 2017 at 11:43:52AM +0200, Jan Mulder wrote:
> > 
> > building on Ubuntu 16.04 was very easy - no issues even with the
> > google maps plugin.
> > i cannot report any issues myself on Ubuntu Xenial.

Again, the issue hasn't been building it locally (at least not on the
newest versions), but packaging it in a way that works. Both Miika and I
have tried unsuccessfully. We are both in Bonaire this week, maybe we can
figure it out. But I won't hold the release for THAT.

> > > - are there any major regressions / massive bugs that I have forgotten about and that should prevent us from releasing 4.7?
> > 
> > i will list some bugs from github here that might need attention:
> > https://github.com/Subsurface-divelog/subsurface/issues/351
> > https://github.com/Subsurface-divelog/subsurface/issues/310
> > https://github.com/Subsurface-divelog/subsurface/issues/311
> > https://github.com/Subsurface-divelog/subsurface/issues/608
> > https://github.com/Subsurface-divelog/subsurface/issues/522
> 
> From this list only 351 and 522 apply to the desktop version. Rest is mobile
> only, so not relevant in the discussion over 4.7

You beat me to that comment. :-)
I marked 351 as must fix for 4.7. That should have been dealt with a long
time ago. The challenge is that it's non-trivial to do so. How do I tell
the difference between "user wants to start with a new file and delete the
dives in their repo" and "user accidentally clicked "new dive log and then
save to ckoud". We could add a warning if all of the dives in the server
side repo are deleted by a save... I'll have to think a bit more about
this - but open to ideas from others as well!

522 is clearly not a show stopper. It's been there for a while and doesn't
seem to stop a lot of people from using Subsurface :-)
Yes, we should fix it eventually.


> > > - what's the state of the translations?
> > > 
> > > It would be great if we could try to get translations and user manual at least looked at in the next few days, and hopefully some testing done with the test binaries that are up.
> 
> Translations for NL/Dutch is complete.

Cool. The solution to 351 might add a new string...

> And I did a very very quick scan of the user manual in English (which I
> consider leading). 2 observations:
> - download from dive computer shows old screendump without Bluetooth option.
> The accompanying text is correct and referencing Bluetooth. So, just
> replacement of screendump

Good catch!

> - the section of GPS recording with Subsurface-mobile shows the old
> credential setup pages. Simply use the image from the latest mobile manual.

Also easy enough to fix.

Thanks.

/D