[PATCH] Make the map widget more pleasant to use

Jan Mulder jlmulder at xs4all.nl
Mon Oct 23 11:31:42 PDT 2017


On 23-10-17 16:26, Linus Torvalds wrote:
> 
>   - if there are no coordinates, do *not* zoom out to the whole-world
>     view. Just leave the map alone.
> 
>   - when zooming out to move to a new dive site, zoom back in to the same
>     zoom level it was before.
> 
> These two changes make it much more pleasant to move between dives,
> particularly as you move back-and-forth without losing the zoom level.
> 
> NOTE! The zoom level gets reset if you move dives _while_ zooming is
> happening, and so moving quickly between dives will still end up losing
> the original zoom level, replacing it with a bigger zoom-out that was
> active _during_ a previous zoom.
> 
> That could be seen as a feature (moving incrementally to an "overview"
> zoom when moving quickly between dive sites), but honestly it smells
> more like a bug to me.  But regardless of that feature/bug, this new
> zoom behavior is more pleasant than our older "always reset when
> moving".
> 
> But it might be a matter of taste, so people should try this out and
> comment.

Tried (as Dirk already merged it into master :-)

In general I like it, one aspect I do not like. I ended my session, 
restart the application, and your previous zoomlevel is gone. And as the 
default is zoomed out very far (I see the whole world), you always have 
to zoom in again.

So, 1) a sensible default zoomlevel (and sensible is the problem here) 
or 2) preserve over sessions.

--jan


More information about the subsurface mailing list