Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

[Aaron Scheiner]

In the attached screenshot the green line is the voted PO2 from the DC (I
changed the colours because... messing around. They're not colour blindness
friendly). On my JJ the reported PO2 from the dive computer (Petrel 2) is
slightly lower than the uncalibrated sensor values.

I've tested saving/loading from XML and saving/loading from git, which work.

In a nutshell I've added an additional field in both libdivecomputer and
Subsurface. If the additional field is populated, Subsurface will use that
instead of trying to average/calculate the PO2.

I still need to test what it does on Android. I still need to clean up
stuff. There's probably a better way of implementing this functionality.

Aaron

On Sun, Jun 17, 2018 at 5:18 PM, Aaron Scheiner <blue at aquarat.za.net> wrote:

> I'm in the same boat and last week I started working on adding an
> additional field to both subsurface and libdivecomputer (I called it voted
> PO2). I managed to get the import and display of it working before I got
> interrupted by other stuff. It has subsequently occurred to me that this
> may not be the best approach.
>
> I'll have a look at it again and try and come up with a better way.
>
> Aaron
>
> On Sun, Jun 17, 2018, 11:53 Davide DB <dbdavide at gmail.com> wrote:
>
>> On Thu, Jun 14, 2018, 15:34 Long, Martin <martin at longhome.co.uk> wrote:
>>
>>> I'm in agreement with Davide that any interim solution we can get
>>> running is better than the way it is working now. It's a regression, and
>>> tbh if there isn't an interim solution then it ought to be reverted to the
>>> old behaviour. At the moment I'm having to use Shearwater desktop for
>>> reviewing all my logs.
>>>
>>
>> I had to stop using Subsurface for the time being. First time in so many
>> years.
>>
>> If the bug will be solved I would have to transfer and compile from
>> scratch more than 60 dives (until now). I don't know if I will have the
>> time or will to do all this work and frankly speaking I'm tired to be
>> always a minority.
>>
>> Farewell my friends. It has been a nice journey. Thank you all for the
>> amazing work.
>>
>>>
>>
>> davide at mobile
>>
>>
>>
>>> _______________________________________________
>> subsurface mailing list
>> subsurface at subsurface-divelog.org
>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20180618/bdb74c48/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screenshot from 2018-06-17 23-48-06.png
Type: image/png
Size: 40900 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20180618/bdb74c48/attachment-0001.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 180617subsurface.diff
Type: text/x-patch
Size: 14948 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20180618/bdb74c48/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 180617subsurface.diff
Type: text/x-patch
Size: 14948 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20180618/bdb74c48/attachment-0003.bin>