load-git and event parsing
Robert C. Helling
helling at atdotde.de
Fri Feb 14 13:48:40 PST 2020
Linus,
> On 14. Feb 2020, at 21:19, Linus Torvalds <torvalds at linux-foundation.org> wrote:
>
> NOTE NOTE NOTE! I really hope Robert can test this. None of my dives
> have dive mode change events. So my testing was pretty darn limited.
my only test case is a dive I created with the planner with a bailout ascent. But I can confirm that your PR loads this dive correctly.
But once more, I have to admit, a quick read through did not really reveal to me how it works when handling multiple strings.
But I thought that given there is no clash between dive mode names and strings that can appear as event names, simply make name=„OC“ and similar a feature. Please have a look at
https://github.com/Subsurface-divelog/subsurface/pull/2622 <https://github.com/Subsurface-divelog/subsurface/pull/2622>
which also fixes the problem.
What do you think?
Best
Robert
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20200214/cababc12/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20200214/cababc12/attachment.sig>
More information about the subsurface
mailing list