[PATCH 2/2] Change tab widget names.

[Thiago Macieira]

On segunda-feira, 8 de abril de 2013 12.18.23, Dirk Hohndel wrote:
> amit.k.chaudhuri at gmail.com writes:
> > diff --git a/qt-ui/maintab.ui b/qt-ui/maintab.ui
> > index a0aec43..1c9b9d1 100644
> > --- a/qt-ui/maintab.ui
> > +++ b/qt-ui/maintab.ui
> > @@ -7,16 +7,16 @@
> > 
> >      <x>0</x>
> >      <y>0</y>
> >      <width>400</width>
> > 
> > -    <height>320</height>
> > +    <height>334</height>
> 
> Is that relevant? Intentional? Caused by a different version of the
> tool? A bug?

That happens if he expanded the window to work on it. But it does change the 
default size...

> >    <property name="currentIndex">
> > 
> > -   <number>0</number>
> > +   <number>3</number>
> > 
> >    </property>
> 
> How about this one? A number changes from 0 to 3. No mention of it in
> the commit message...

This is also probably the result of saving the file after exploring the UI.

However, it's also changing which tab is presented by default. This change 
should not be done, unless it was intentional.

> Maybe we need a sub-maintainer (clearly one of the people doing the
> majority of the work on the Qt UI) who simply owns the UI and gets to be
> the one to make sure changes like this are sane and make sense?

I'd recommend reading the diff just to make sure that some of the defaults 
weren't changed unnecessarily. The size isn't a big deal, since the window 
will be resized to fit the contents. But changing the default tab might be a 
bad idea.

> How do other projects handle this, Thiago?

Unfortunately, these files churn a lot. I did a git log -p -- \*.ui in kdelibs 
to check and I ran into this change:

--- a/kate/swapfile/recoverwidget.ui
+++ b/kate/swapfile/recoverwidget.ui
@@ -6,24 +6,51 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>458</width>
-    <height>72</height>
+    <width>713</width>
+    <height>82</height>
    </rect>
  </property>
-  <property name="windowTitle">
-   <string/>
-  </property>

It shows the same problem: the contributor resized the window to work on it, 
and the size was saved in the file. It also shows a new version of the tool 
removing an unset property. There were also plenty of changes to other files 
removing a space before the closing > in many tags (new version of the XML 
generator).

I would recommend git add -p and avoid unnecessary changes whenever possible. 
You don't need to split your head open to make a nice XML change if Designer 
changed a lot, but simple changes should be doable.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130408/b4182ed4/attachment.sig>